[PATCH] JDK-8159797 Throw a right IllegalArgumentException from the bytecode generated by Method/ConstructorAccessor (original) (raw)

Thu May 3 12:53:52 UTC 2018

 // Access flags
 public static final short ACC_PUBLIC = (short) 0x0001;
   // ifnull <null args label>
   // aload_2 | aload_1
   // arraylength
   // goto <arg count check label>
   // <null args label:>
   // iconst_0
   // <arg count check label:>
   // sipush <num parameter types>
   // if_icmpeq <success label>
   // new <IllegalArgumentException>
   Label nullArgsLabel = new Label();
   Label argCountCheckLabel = new Label();
   cb.opc_ifnull(nullArgsLabel);
   if (isConstructor) {
       cb.opc_aload_1();
   } else {
       cb.opc_aload_2();
   }
   cb.opc_arraylength();
   cb.opc_goto(argCountCheckLabel);
   nullArgsLabel.bind();
   cb.emitByte(ClassFileConstants.opc_iconst_0);
   argCountCheckLabel.bind();
   cb.opc_sipush((short) parameterTypes.length);
   cb.opc_if_icmpeq(successLabel);
   cb.opc_new(illegalArgumentClass);
  doMethodTests();
  doConstructorTests();
  final Method method = MethodAccessGeneratorTest.class.getMethod("doSomething", String.class); 
  final MethodAccessor methodAccessor = ReflectionFactory.getReflectionFactory().newMethodAccessor(method);
  if (!methodAccessor.getClass().getName().startsWith("jdk.internal.reflect.GeneratedMethodAccessor")) {
     throw new RuntimeException("Unexpected MethodAccessor class " + methodAccessor.getClass().getName());
  }
  final MethodAccessGeneratorTest self = new MethodAccessGeneratorTest();
  // intentionally pass wrong args
  try {
     methodAccessor.invoke(self, null);
     throw new RuntimeException("Expected a IllegalArgumentException, but didn't receive one");
  } catch (IllegalArgumentException iae) {
     assertMessageNotNPE(iae);
  }
  try {
     methodAccessor.invoke(self, new String[] {"one", "two"});
     throw new RuntimeException("Expected a IllegalArgumentException, but didn't receive one");
  } catch (IllegalArgumentException iae) {
     assertMessageNotNPE(iae);
  }
  // pass valid args
  methodAccessor.invoke(self, new String[] {"hello world"});
  methodAccessor.invoke(self, new Object[] {null});
  final Constructor constructor = SomeClass.class.getConstructor(new Class[] {String.class}); 
  final ConstructorAccessor constructorAccessor = ReflectionFactory.getReflectionFactory().newConstructorAccessor(constructor);
  if (!constructorAccessor.getClass().getName().startsWith("jdk.internal.reflect.GeneratedConstructorAccessor")) {
     throw new RuntimeException("Unexpected MethodAccessor class " + constructorAccessor.getClass().getName());
  }
  // intentionally pass wrong args
  try {
     constructorAccessor.newInstance(null);
     throw new RuntimeException("Expected a IllegalArgumentException, but didn't receive one");
  } catch (IllegalArgumentException iae) {
     assertMessageNotNPE(iae);
  }
  try {
     constructorAccessor.newInstance(new String[] {"one", "two"});
     throw new RuntimeException("Expected a IllegalArgumentException, but didn't receive one");
  } catch (IllegalArgumentException iae) {
     assertMessageNotNPE(iae);
  }
  // pass valid args
  constructorAccessor.newInstance(new String[] {"hello world"});
  constructorAccessor.newInstance(new Object[] {null});
  if (iae.getMessage() != null  && iae.getMessage().contains(NullPointerException.class.getName())) {
     throw new RuntimeException("IllegalArgumentException's message contains NullPointerException", iae);
  }
  public SomeClass(final String val) {
  }

[PATCH] JDK-8159797 Throw a right IllegalArgumentException from the bytecode generated by Method/ConstructorAccessor (original) (raw)

HG changeset patch

User Jaikiran Pai <jaikiran.pai at gmail.com>

Date 1525350350 -19800

Thu May 03 17:55:50 2018 +0530

Node ID 2b535248cf02d90f6fea1c89150a277f16954c04

Parent 7379e6f906aeb6e69ed8eccda9de285e606ab1ff