RFR: 8203223: Signed integer overflow in ImageStrings::hash_code (libjimage.so) (original) (raw)
David Holmes david.holmes at oracle.com
Wed May 16 02:01:42 UTC 2018
- Previous message: RFR: 8203223: Signed integer overflow in ImageStrings::hash_code (libjimage.so)
- Next message: RFR: 8203223: Signed integer overflow in ImageStrings::hash_code (libjimage.so)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
+1 on both comments.
In addition I'd prefer
u4 useed = (u4)seed;
for clarity, rather than just 's'.
Thanks, David
On 16/05/2018 2:16 AM, Aleksey Shipilev wrote:
On 05/15/2018 06:11 PM, Severin Gehwolf wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8203223 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8203223/webrev.01/ *) Um: assert(seed > 0 && "invariant"); This should be this, right? assert(seed > 0, "invariant"); *) I would also write: return (s4)s & 0x7FFFFFFF; as return (s4)(s & 0x7FFFFFFF); -Aleksey
- Previous message: RFR: 8203223: Signed integer overflow in ImageStrings::hash_code (libjimage.so)
- Next message: RFR: 8203223: Signed integer overflow in ImageStrings::hash_code (libjimage.so)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]