8202076: test/jdk/java/io/File/WinSpecialFiles.java on windows with VS2017 (original) (raw)

Brian Burkhalter brian.burkhalter at oracle.com
Fri May 18 23:55:09 UTC 2018

Hi Ivan,

All good ideas for next week!

Thanks,

Brian

On May 18, 2018, at 4:49 PM, Ivan Gerasimov <ivan.gerasimov at oracle.com> wrote:

Thanks Brian, the last webrev looks good to me!

I minor suggestion is that I would recommend to use L'\' to explicitly indicate it is a wide char literal. And the last comment: Maybe it makes sense to update the test java/io/File/WinSpecialFiles.java to make sure we deal correctly with wildcards in a file name (and that nobody will accidentally optimize away the check of the filename).

More information about the core-libs-dev mailing list