RFR: Small cleanups in java.lang.ref (original) (raw)

Kim Barrett kim.barrett at oracle.com
Sun May 20 15:31:07 UTC 2018

On May 18, 2018, at 4:47 PM, Martin Buchholz <martinrb at google.com> wrote:

On Fri, May 18, 2018 at 3:26 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:

Hi,

On Wed, 2018-05-16 at 18:31 -0700, Martin Buchholz wrote: I've been confused by NULL vs null for years.

8203327: Small cleanups in java.lang.ref http://cr.openjdk.java.net/~martin/webrevs/jdk/Reference-cleanup/ https://bugs.openjdk.java.net/browse/JDK-8203327 JDK-8203028 which is currently out for review (http://cr.openjdk.java .net/~kbarrett/8203028/open.02) changes and fixes the comments in that respect apart from other significant changes to reference processing.

Thomas - thanks for noticing this conflict. I’m a bit behind on watching the core-libs mailing list.

Pushing this cleanup would just cause merge conflicts for us (the gc team). So this change does not seem to be required any more, i.e. do you mind retracting this RFR and closing this change as duplicate of the other?

(I apologize if my speech is too direct, I do not want to offend) On the contrary, I'm very happy to see gc team actively maintaining java.lang.ref.

GC team is actively involved here. If you look at the change history in this area for the last few years, you’ll usually find either Mandy or me as the author and the other as a reviewer.

I've reverted changes to Reference.java

http://cr.openjdk.java.net/~martin/webrevs/jdk/Reference-cleanup-1/

Thanks for reverting that part.

Any additional comments on 8203028 would be welcome.

More information about the core-libs-dev mailing list