8203487: Typo in ICUBinary.java: s/Magin/Magic/ (original) (raw)

Ivan Gerasimov ivan.gerasimov at oracle.com
Mon May 21 17:00:26 UTC 2018

Looks good!

With kind regards,

Ivan

On 5/21/18 9:57 AM, Brian Burkhalter wrote: > https://bugs.openjdk.java.net/browse/JDK-8203487 >> --- a/src/java.base/share/classes/sun/text/normalizer/ICUBinary.java > +++ b/src/java.base/share/classes/sun/text/normalizer/ICUBinary.java > @@ -255,7 +255,7 @@ > * Error messages > */ > private static final String MAGICNUMBERAUTHENTICATIONFAILED = > - "ICUBinary data file error: Magin number authentication failed"; > + "ICUBinary data file error: Magic number authentication failed"; > private static final String HEADERAUTHENTICATIONFAILED = > "ICUBinary data file error: Header authentication failed"; > } >> Thanks, >> Brian >> On May 21, 2018, at 9:50 AM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote: >>> Hi Adam, >>>> I’ll take it. >>>> Thanks, >>>> Brian >>>> On May 21, 2018, at 9:01 AM, Adam Farley8 <adam.farley at uk.ibm.com> wrote: >>>>> There's a typo here on line 258, where is says "Magin number" but means >>> "Magic number". >>>>>> http://hg.openjdk.java.net/jdk/jdk/file/ec881a19d294/src/java.base/share/classes/sun/text/normalizer/ICUBinary.java >>>>>>>>> Can a committer review and correct the typo? >

With kind regards, Ivan Gerasimov

More information about the core-libs-dev mailing list