RFR: 8177276: MethodHandles.insertArguments doesn't specify IllegalArgumentException on index mismatch (original) (raw)

mandy chung mandy.chung at oracle.com
Tue May 22 16:36:35 UTC 2018

On 5/22/18 9:09 AM, Vivek Theeyarath wrote:

Hi All, Thanks for the comments. I have incorporated the changes as per Nadeesh's and Paul's comments. The test runs fine with jtreg post the changes. Also, the typo errors Mandy pointed out has also been fixed. Please find the updated webrev.

http://cr.openjdk.java.net/~vtheeyarath/8177276/webrev.03/

Looks fine.   Nit:  line 119-133 in MethodHandlesInsertArgumentsTest.java can be converted into two  @Test(expected = ClassCastException.class) cases like the other two IAE cases.  You can update it before you push.

Mandy

More information about the core-libs-dev mailing list