[core-libs] RFR (L): 8010319: Implementation of JEP 181: Nest-Based Access Control (original) (raw)

mandy chung mandy.chung at oracle.com
Wed May 23 00:56:26 UTC 2018

On 5/22/18 3:15 AM, David Holmes wrote:

Here are the updates so far in response to all the review comments.

Incremental webrev: http://cr.openjdk.java.net/~dholmes/8010319-JEP181/webrev.corelibs.v2-incr/ Full webrev: http://cr.openjdk.java.net/~dholmes/8010319-JEP181/webrev.corelibs.v2/

thanks for the update.  Looks good in general.

SampleNest.java

  33     static List<Class> _nestedTypes = new LinkedList>();

This can use the diamond expression i.e. new LinkedList<>().

TestReflectionAPI.java

Thanks for covering many test cases.

 263                 Class[] memberSet =  264                     new HashSet>(Arrays.asList(members)).toArray(new Class<?>[0]);

It can be simplified using Stream:

   Class[] memberSet = Arrays.stream(members).toArray(Class[]::new);

Mandy

More information about the core-libs-dev mailing list