RFR: implementation for JEP 334: JVM Constants API (original) (raw)

Andrej Golovnin andrej.golovnin at gmail.com
Thu May 24 07:46:55 UTC 2018

Hi Vincente,

the following files do not have the copyright header:

src/java.base/share/classes/java/lang/invoke/FieldTypeDescriptor.java src/java.base/share/classes/java/lang/invoke/MethodTypeDescriptor.java src/java.base/share/classes/java/lang/invoke/TypeDescriptor.java

In the following files the year in the copyright should be updated:

test/jdk/java/lang/invoke/constant/ClassRefTest.java test/jdk/java/lang/invoke/constant/CondyRefTest.java test/jdk/java/lang/invoke/constant/MethodHandleRefTest.java test/jdk/java/lang/invoke/constant/MethodTypeRefTest.java test/jdk/java/lang/invoke/constant/SymbolicRefTest.java test/jdk/java/lang/invoke/constant/TypeDescriptorTest.java

And I also think that Constable.describeConstable() is weirdly named. What about:

#describe() #getDescriptor() #getConstantDescriptor() #toConstantDescriptor()

Best regards, Andrej Golovnin

On Wed, May 23, 2018 at 8:41 PM, Vicente Romero <vicente.romero at oracle.com> wrote:

Hi all,

Please review the proposed implementation for JEP 334 [1]. The webrev can be found at [2] and the javadoc at [3]. Thanks, Vicente [1] https://bugs.openjdk.java.net/browse/JDK-8203252 [2] http://cr.openjdk.java.net/~vromero/constant.api/webrev.07/constants.api.patch [3] http://cr.openjdk.java.net/~vromero/constant.api/javadoc.07/overview-summary.html PS. We are offering a MacBook Wheel to the authors of the first 5 comments :)

More information about the core-libs-dev mailing list