RFR: JDK-8203827: Upgrade JLine to 2.14.6 (original) (raw)

Jan Lahoda jan.lahoda at oracle.com
Tue May 29 16:11:55 UTC 2018

Hi Hannes,

On 29.5.2018 17:32, Hannes Wallnöfer wrote:

Hi Jan,

Nashorn changes look good. I noticed one slight change of behaviour in jjs. When I enter „java.m“ and hit the tab key, it autocompletes to „java.math “, adding a space character at the end. This is a bit inconvenient, and the old version of jline didn’t do that.

Thanks for finding that, and sorry I didn't notice (jshell is using its own completion handler, so did not suffer from this). It should be possible to disable this in jjs, will do and will send updated webrev.

Thanks, Jan

Hannes

Am 25.05.2018 um 22:20 schrieb Jan Lahoda <jan.lahoda at oracle.com>: Hi, I'd like to upgrade the JLine used by JShell and jjs from 2.12.1 to 2.14.6. The complete webrev is here: http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/complete/ To simplify reviewing, there is: -an antipatch that removes the JDK-specific changes and restores the vanilla 2.12.1 content: http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/undo-jdk-extras/ -a patch that replaces the 2.12.1 content with 2.14.6: http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/upgrade-jline/ -a patch that re-applies the JDK-specific changes (like including adjusting packages, and removal/commenting out of usage of features that would require undesirable dependencies, and any changes that had to be done to other modules): http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/adding-jdk-extras/ JBS entry: https://bugs.openjdk.java.net/browse/JDK-8203827 How does this look? Thanks, Jan

More information about the core-libs-dev mailing list