RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1 (original) (raw)
Ichiroh Takiguchi takiguc at linux.vnet.ibm.com
Thu May 31 07:55:12 UTC 2018
- Previous message: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1
- Next message: RFR: JDK-8190187: C++ code calling JNI_CreateJavaVM can be killed by Java - Final Email
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hello. 8202322 was integrated into jdk-11+15. I'm using XLC 13.1.3 on AIX 7.1.4. Build was failed because of "-qvisibility=hidden" on make/lib/LibCommon.gmk. According to "XL C/C++ for AIX 13.1.3" documentation [1], "-qvisibility=hidden" cannot create shared libraries entry points. For example, libverify.so was there, but entry points were not resolved by "-lverify" option. I think it should be "-qvisibility=default" (I tried, it worked) or "-qvisibility=protected" (I had not tried) ? I'm not familiar with -qvisibility option, but I'd like to find out right way.
On 2018-05-16 16:08, Langer, Christoph wrote:
Hi Matthias,
yes, reviewed. Best regards Christoph From: Baesken, Matthias Sent: Mittwoch, 16. Mai 2018 09:06 To: Langer, Christoph <christoph.langer at sap.com>; 'build-dev at openjdk.java.net' <build-dev at openjdk.java.net>; ppc-aix-port-dev at openjdk.java.net; core-libs-dev at openjdk.java.net Cc: Lindenmaier, Goetz <goetz.lindenmaier at sap.com> Subject: RE: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1 Hi Christoph can I add you as second reviewer (other reviewer was Erik Joelsson) can push the change ? Best regards, Matthias
From: Langer, Christoph Sent: Donnerstag, 26. April 2018 16:38 To: Baesken, Matthias <matthias.baesken at sap.com<mailto:matthias.baesken at sap.com>>; 'build-dev at openjdk.java.net' <build-dev at openjdk.java.net<mailto:build-dev at openjdk.java.net>>; ppc-aix-port-dev at openjdk.java.net<mailto:ppc-aix-port-dev at openjdk.java.net>; core-libs-dev at openjdk.java.net<mailto:core-libs-dev at openjdk.java.net> Cc: Simonis, Volker <volker.simonis at sap.com<mailto:volker.simonis at sap.com>> Subject: RE: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1 Hi Matthias, to me the change in principal looks good. I'm wondering if it is possible to do a comparison like xlc < 13 (e.g._ _extract major number before the first dot, then compare numerically) -_ _but maybe it is too complicated and the current single version compare_ _suits our needs ?_ _Best regards_ _Christoph_ _From: Baesken, Matthias_ _Sent: Donnerstag, 26. April 2018 16:14_ _To: 'build-dev at openjdk.java.net'_ _<build-dev at openjdk.java.net<mailto:build-dev at openjdk.java.net>>; ppc-aix-port-dev at openjdk.java.net<mailto:ppc-aix-port-dev at openjdk.java.net>; core-libs-dev at openjdk.java.net<mailto:core-libs-dev at openjdk.java.net> Cc: Langer, Christoph <christoph.langer at sap.com<mailto:christoph.langer at sap.com>>; Simonis, Volker <volker.simonis at sap.com<mailto:volker.simonis at sap.com>> Subject: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1 Hello , could you please review this small adjustment to the symbol visibility compilation settings on AIX ? Currently we use XLC 12.1 to compile JDK on AIX . However XLC 12.1 does not support the "-qvisibility=hidden" setting currently set on AIX. It was introduced with XLC 13.1 . Christoph found some info about it here : https://www.ibm.com/developerworks/aix/library/au-aix-symbol-visibility-part2/index.html Setting it only generates hundreds of warnings in the build log , warnings look like this : XlC12.1 bash-4.4$ xlC -qversion IBM XL C/C++ for AIX, V12.1 (5765-J02, 5725-C72) Version: 12.01.0000.0019 bash-4.4$ xlC -qvisibility=hidden sizeof.c -o sizeofaixxlc 1506-173 (W) Option visibility=hidden is not valid. Enter xlC for list of valid options. Compare to XLC13.1 bash-3.00$ xlC -qversion IBM XL C/C++ for AIX, V13.1 (5725-C72, 5765-J07) Version: 13.01.0000.0008 bash-3.00$ xlC -qvisibility=default sizeof.c -o sizeofaixxlc bash-3.00$ xlC -qvisibility=hidden sizeof.c -o sizeofaixxlc So it is better to avoid setting these flags when using xlc12.1 . Please review : Bug : https://bugs.openjdk.java.net/browse/JDK-8202322 Change : http://cr.openjdk.java.net/~mbaesken/webrevs/8202322/ Best regards, Matthias
- Previous message: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1
- Next message: RFR: JDK-8190187: C++ code calling JNI_CreateJavaVM can be killed by Java - Final Email
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]