RFR: 8204194: Lazily create MethodHandleImpl$AsVarargsCollector.asCollectorCache (original) (raw)
Paul Sandoz paul.sandoz at oracle.com
Thu May 31 22:13:24 UTC 2018
- Previous message: RFR: 8204194: Lazily create MethodHandleImpl$AsVarargsCollector.asCollectorCache
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
+1
Paul.
On May 31, 2018, at 2:24 PM, Claes Redestad <claes.redestad at oracle.com> wrote:
Hi, please review this tiny fix that removes the eager creation of asCollectorCache, which saves us a few milliseconds on certain startup tests with no observed peak performance penalties. Bug: https://bugs.openjdk.java.net/browse/JDK-8204194 Patch: [1] Thanks! /Claes [1] diff -r 80c69f5cd21a src/java.base/share/classes/java/lang/invoke/MethodHandleImpl.java --- a/src/java.base/share/classes/java/lang/invoke/MethodHandleImpl.java Thu May 31 06:15:17 2018 -0700 +++ b/src/java.base/share/classes/java/lang/invoke/MethodHandleImpl.java Thu May 31 23:23:03 2018 +0200 @@ -499,7 +499,6 @@ super(type, target); this.target = target; this.arrayType = arrayType; - this.asCollectorCache = target.asCollector(arrayType, 0); } @Override
- Previous message: RFR: 8204194: Lazily create MethodHandleImpl$AsVarargsCollector.asCollectorCache
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]