[concurrency-interest] Durations in existing JDK APIs (original) (raw)

Gregg Wonderly gergg at cox.net
Thu May 31 02:43:21 UTC 2018

I am not sure I understand this implementation, but isn’t

long s = convert(duration.getSeconds(), SECONDS);

needing to actually be

long s = convert(duration.getSeconds(), NANOSECONDS);

so that s+n is in a common unit of measure?

Gregg

On May 30, 2018, at 7:19 PM, Martin Buchholz via Concurrency-interest <concurrency-interest at cs.oswego.edu> wrote:

v.0.2 has both conversion methods in TimeUnit. The unexpected weirdness is that convert(Duration) saturates while toDuration throws ArithmeticException, but both seem author-culture-consistent. Perhaps TimeUnit#toDuration doesn't provide enough value in view of the existing Duration.of and TimeUnit#toChronoUnit. And most of the time you'd expect to convert from Duration to long, just before calling a TimeUnit based method. /** * Converts the given time duration to this unit. * * @param duration the time duration * @return the converted duration in this unit, * or {@code Long.MINVALUE} if conversion would negatively overflow, * or {@code Long.MAXVALUE} if it would positively overflow. * @throws NullPointerException if {@code duration} is null */ public long convert(Duration duration) { long s = convert(duration.getSeconds(), SECONDS); if (s == Long.MINVALUE) return s; long n = convert(duration.getNano(), NANOSECONDS); assert n >= 0 && n < 1000000000; return (s + n < s) ? Long.MAXVALUE : s + n; } /** * Converts the given time duration in this unit to a Duration. * * @param duration the time duration * @return the time duration represented as a Duration * @throws ArithmeticException if the duration cannot be represented * as a Duration due to numeric overflow */ public Duration toDuration(long duration) { return Duration.of(duration, toChronoUnit()); }

Concurrency-interest mailing list Concurrency-interest at cs.oswego.edu http://cs.oswego.edu/mailman/listinfo/concurrency-interest

More information about the core-libs-dev mailing list