review (S) for 6885584: A particular class structure causes large allocation spike for jit (original) (raw)

Tom Rodriguez Thomas.Rodriguez at Sun.COM
Wed Oct 7 11:02:10 PDT 2009

On Oct 6, 2009, at 5:14 PM, Vladimir Kozlov wrote:

Tom,

For longs it is possible that max < maxjuint. So can we change the next condition:

You're right. I recoded it as:

       if (max >= max_juint && _hi < max_juint)

tom

if (hi < maxjuint) return make(lo, maxjuint, WidenMax); else return make(lo, max, WidenMax); to next?: if (hi < maxjuint && maxjuint < max) return make(lo, maxjuint, WidenMax); else return make(lo, max, WidenMax); Vladimir Tom Rodriguez wrote: On Oct 6, 2009, at 4:42 PM, Vladimir Kozlov wrote:

Tom, why changes are different for Int and Long? For longs you replaced maxjlong, minjlong with max,min I did them separately and didn't notice that they were different. I've fixed them to be the same. tom in make() parameters and conditions.

Vladimir Tom Rodriguez wrote: http://cr.openjdk.java.net/~never/6885584

More information about the hotspot-compiler-dev mailing list