review (S) for 6891770: JSR 292 API needs initial unit tests (original) (raw)

Christian Thalinger Christian.Thalinger at Sun.COM
Thu Oct 15 08:33:40 PDT 2009

On Thu, 2009-10-15 at 01:47 -0700, John Rose wrote:

Here is the first JUnit-based test for JSR 292: http://cr.openjdk.java.net/~jrose/6891770/webrev.00

I downloaded the modified jtreg version you mentioned in your earlier email, copied the make files from a jdk test directory and ran the tests with:

$ make JPRT_JTREG_HOME=$HOME/mlvm/jtreg-no-junit/jtreg PRODUCT_HOME= $HOME/mlvm/hotspot/build/solaris/jdk-solaris-i586/debug/ TESTDIRS=test

and the run was:

TEST: test/java/dyn/MethodHandlesTest.java TEST RESULT: Passed. Execution successful

Test results: passed: 1

So, the changes look good.

-- Christian