Request for reviews (M): 6829192: JSR 292 needs to support 64-bit x86 (original) (raw)

Christian Thalinger Christian.Thalinger at Sun.COM
Wed Oct 21 08:15:15 PDT 2009

On Tue, 2009-10-20 at 17:32 -0700, Vladimir Kozlov wrote:

src/cpu/x86/vm/interpmasmx8664.cpp: In InterpreterMacroAssembler::getcacheindexatbcp() the assert is not clear. Add comment and explain what you are testing to how next instruction should be changed.

Added.

src/cpu/x86/vm/templateInterpreterx8664.cpp: In TemplateInterpreterGenerator::generateWrongMethodTypehandler() what rbx and rax contain and why you need to verify oop?

I can only tell what the registers contain, John should know why it needs to be verified.

I don't like outline code in generatereturnentryfor(). Why do you need to move it down?

I guess John wrote it that way because it's not the default case. John?

src/share/vm/classfile/classFileParser.cpp: Don't leave commented code. Remove it if you don't need it.

Yeah, that commented code was just a hack to get it working, the real fix is to add this field "magically". John and I decided to do that after M5. But I will remove the commented code.

-- Christian

More information about the hotspot-compiler-dev mailing list