review for 6990212: JSR 292 JVMTI MethodEnter hook is not called for JSR 292 bootstrap and target methods (original) (raw)

Christian Thalinger christian.thalinger at oracle.com
Mon Jul 11 09🔞09 PDT 2011

• Previous message: review for 6990212: JSR 292 JVMTI MethodEnter hook is not called for JSR 292 bootstrap and target methods
• Next message: review for 6990212: JSR 292 JVMTI MethodEnter hook is not called for JSR 292 bootstrap and target methods
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Jul 11, 2011, at 5:43 PM, Christian Thalinger wrote:

On Jul 9, 2011, at 12:21 AM, Tom Rodriguez wrote:

Coleen point out that it's confusing to reuse the name jumpfrominterpreted since we're not really in the interpreter. I've changed it to jumpfrommethodhandle and left that note that it parallels jumpfrominterpreted. This looks good.

Looking at it again I think the SPARC code is wrong:

• const Address interp_only(G2_thread, JavaThread::interp_only_mode_offset());

• __ ld(interp_only, temp);

• __ tst(temp);

• __ br(Assembler::notZero, true, Assembler::pn, skip_compiled_code);

• __ delayed()->nop();

• __ jump_indirect_to(Address(method, methodOopDesc::interpreter_entry_offset()), temp);

• __ bind(skip_compiled_code);

It should be:

• __ br(Assembler::zero, false, Assembler::pt, run_compiled_code);

-- Christian

• Previous message: review for 6990212: JSR 292 JVMTI MethodEnter hook is not called for JSR 292 bootstrap and target methods
• Next message: review for 6990212: JSR 292 JVMTI MethodEnter hook is not called for JSR 292 bootstrap and target methods
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the hotspot-compiler-dev mailing list