review for 7012081: JSR 292: SA-JDI can't read MH/MT/Indy ConstantPool entries (original) (raw)

Tom Rodriguez tom.rodriguez at oracle.com
Mon Jul 11 10:50:14 PDT 2011

On Jul 11, 2011, at 12:57 AM, Christian Thalinger wrote:

On Jul 9, 2011, at 12:23 AM, Tom Rodriguez wrote:

http://cr.openjdk.java.net/~never/7012081 564 lines changed: 285 ins; 193 del; 86 mod; 7784 unchg

7012081: JSR 292: SA-JDI can't read MH/MT/Indy ConstantPool entries Summary: Reviewed-by: There we a bunch of changes to the constant pool and bytecode classes which were never reflected in the SA so it would break when looking at classes using 292 features. The fix is simply to make the SA code mirror the JVM code again. Primarily this was the code dealing with the size of index values for various bytecodes. The generateOopMap.cpp change is purely a formatting change to make it more regular. After these changes some of the tests still fail but this is because of test bugs that will be fixed separately. Tested with failing tests including the tmtools and sajdi suites which exercises the SA extensively. agent/src/share/classes/sun/jvm/hotspot/interpreter/BytecodeLoadConstant.java: Is the debugging code in isValid intentional?

No. Thanks for catching that. I've fixed it.

tom

Otherwise looks good. -- Christian

More information about the hotspot-compiler-dev mailing list