Request for review (XXS): 7041244: JSR 292: Server VM gets a SEGV running a JCK test (original) (raw)

Christian Thalinger christian.thalinger at oracle.com
Wed May 4 00:42:35 PDT 2011

• Previous message: Request for review (XXS): 7041244: JSR 292: Server VM gets a SEGV running a JCK test
• Next message: Request for review (XXS): 7041244: JSR 292: Server VM gets a SEGV running a JCK test
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Thank you all for the review. I'm going to add a small compiler warning fix that I introduced with 7018355:

diff -r 2e038ad0c1d0 src/share/vm/memory/genOopClosures.hpp --- a/src/share/vm/memory/genOopClosures.hpp +++ b/src/share/vm/memory/genOopClosures.hpp @@ -175,7 +175,7 @@ class VerifyOopClosure: public OopClosur protected: template inline void do_oop_work(T* p) { oop obj = oopDesc::load_decode_heap_oop(p);

• guarantee(obj->is_oop_or_null(), err_msg("invalid oop: " INTPTR_FORMAT, obj));

• guarantee(obj->is_oop_or_null(), err_msg("invalid oop: " INTPTR_FORMAT, (oopDesc*) obj));

} public: virtual void do_oop(oop* p);

-- Christian

On May 3, 2011, at 7:19 PM, Tom Rodriguez wrote:

Looks good.

tom On May 3, 2011, at 2:52 AM, Christian Thalinger wrote:

http://cr.openjdk.java.net/~twisti/7041244/

7041244: JSR 292: Server VM gets a SEGV running a JCK test Reviewed-by: The call to checkklasssubtype in adaptercheckcast uses O0 as a temporary register which may be later used in the exception throwing path in vmarg to reload the bad object. The fix is to use O3 instead of O0 which is also free at this point. src/cpu/sparc/vm/methodHandlessparc.cpp

• Previous message: Request for review (XXS): 7041244: JSR 292: Server VM gets a SEGV running a JCK test
• Next message: Request for review (XXS): 7041244: JSR 292: Server VM gets a SEGV running a JCK test
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the hotspot-compiler-dev mailing list