review for 7047961: JSR 292 MethodHandleWalk swap args doesn't handle T_LONG and T_DOUBLE properly (original) (raw)

John Coomes John.Coomes at oracle.com
Wed May 25 12:45:11 PDT 2011

• Previous message: review for 7047961: JSR 292 MethodHandleWalk swap args doesn't handle T_LONG and T_DOUBLE properly
• Next message: review for 7047961: JSR 292 MethodHandleWalk swap args doesn't handle T_LONG and T_DOUBLE properly
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Tom Rodriguez (tom.rodriguez at oracle.com) wrote:

http://cr.openjdk.java.net/~never/7047961 316 lines changed: 213 ins; 27 del; 76 mod; 5061 unchg

7047961: JSR 292 MethodHandleWalk swap args doesn't handle TLONG and TDOUBLE properly ...

Not a real review, just a nit-pick: '#ifdef DEBUG' should be '#ifdef ASSERT' since DEBUG is not defined consistently in our builds (e.g., not in fastdebug builds).

-John

• Previous message: review for 7047961: JSR 292 MethodHandleWalk swap args doesn't handle T_LONG and T_DOUBLE properly
• Next message: review for 7047961: JSR 292 MethodHandleWalk swap args doesn't handle T_LONG and T_DOUBLE properly
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the hotspot-compiler-dev mailing list