Request for reviews (M): 7085860: JSR 292: implement CallSite.setTargetNormal and setTargetVolatile as native methods (original) (raw)

Tom Rodriguez tom.rodriguez at oracle.com
Wed Sep 7 11:52:30 PDT 2011

On Sep 7, 2011, at 6:37 AM, Christian Thalinger wrote:

http://cr.openjdk.java.net/~twisti/7085860/

7085860: JSR 292: implement CallSite.setTargetNormal and setTargetVolatile as native methods Reviewed-by: The current push notification of CallSites disallows the compilation of CallSite.setTargetNormal and setTargetVolatile to get correct behavior. It would be much easier and cleaner if these two methods were native methods in the JVM.

The JVM changes look fine, though the name obj_field_volatile_put doesn't read that well. Maybe obj_field_put_volatile? I know it matches the raw_put name but you could change that too. Anyway, it's a nit, so feel free to ignore it.

In CallSite.java you can delete the other Unsafe stuff since it's no longer needed. Otherwise it looks good.

tom

The obsolete code will be removed after the JDK changes have landed with: 7087357: JSR 292: remove obsolete code after 7085860 src/share/vm/classfile/javaClasses.cpp src/share/vm/classfile/javaClasses.hpp src/share/vm/oops/oop.hpp src/share/vm/oops/oop.inline.hpp src/share/vm/prims/methodHandles.cpp jdk/src/share/classes/java/lang/invoke/CallSite.java jdk/src/share/classes/java/lang/invoke/MethodHandleNatives.java

More information about the hotspot-compiler-dev mailing list