review for 7088020: SEGV in JNIHandleBlock::release_block (original) (raw)

Tom Rodriguez tom.rodriguez at oracle.com
Wed Sep 7 15:44:56 PDT 2011


On Sep 7, 2011, at 2:24 PM, Vladimir Kozlov wrote:

Where r12 is restored? It contains coop base.

I forgot to add the reinit_heapbase call. I've updated the webrev. Surprisingly my tests didn't crash. I ran some more tests and found a problem with stack walking for throw_NullPointerException_at_call. I'm looking into it.

tom

Vladimir Tom Rodriguez wrote: http://cr.openjdk.java.net/~never/7088020 150 lines changed: 88 ins; 50 del; 12 mod; 10143 unchg 7088020: SEGV in JNIHandleBlock::releaseblock Reviewed-by: The throwWrongMethodTypeException stub on x64 needs to align the stack before calling into the runtime or it might crash. I also noticed that two stubs were dead which made an extra argument dead so I cleaned that up at the same time. Tested on linux-amd64 with new regression test and failing tests from report.



More information about the hotspot-compiler-dev mailing list