Request for reviews (M): 7085860: JSR 292: implement CallSite.setTargetNormal and setTargetVolatile as native methods (original) (raw)

Christian Thalinger christian.thalinger at oracle.com
Thu Sep 8 03:03:49 PDT 2011


On Sep 7, 2011, at 9:09 PM, John Rose wrote:

On Sep 7, 2011, at 6:37 AM, Christian Thalinger wrote:

http://cr.openjdk.java.net/~twisti/7085860/

7085860: JSR 292: implement CallSite.setTargetNormal and setTargetVolatile as native methods Reviewed-by: Yes, looks good. (I agree with Tom that "volatileput" is harder to read than "putvolatile". In the latter formulation, "volatile" modifies "put" more clearly.)

I renamed the two methods (raw and volatile) and added the new methods to klassOop too (it looks like that is required). The webrev is updated.

-- Christian

Will there be a separate bug for throttling megamutable sites, after Tom's field injection stuff goes in? -- John

-------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20110908/88bde146/attachment.html



More information about the hotspot-compiler-dev mailing list