Request for reviews (M): 7085860: JSR 292: implement CallSite.setTargetNormal and setTargetVolatile as native methods (original) (raw)

Charles Oliver Nutter headius at headius.com
Thu Sep 8 13:13:03 PDT 2011

• Previous message: Request for reviews (M): 7085860: JSR 292: implement CallSite.setTargetNormal and setTargetVolatile as native methods
• Next message: Request for reviews (S): 7054211: No loop unrolling done in jdk7b144 for a test update() while loop
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Wed, Sep 7, 2011 at 2:09 PM, John Rose <john.r.rose at oracle.com> wrote:

Yes, looks good.  (I agree with Tom that "volatileput" is harder to read than "putvolatile".  In the latter formulation, "volatile" modifies "put" more clearly.)

"volatile put" says to me "it may or may not happen...it's volatile like that!" :)

• Charlie

• Previous message: Request for reviews (M): 7085860: JSR 292: implement CallSite.setTargetNormal and setTargetVolatile as native methods
• Next message: Request for reviews (S): 7054211: No loop unrolling done in jdk7b144 for a test update() while loop
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the hotspot-compiler-dev mailing list