review for 7092236: java/util/EnumSet/EnumSetBash.java fails (original) (raw)

John Rose john.r.rose at oracle.com
Tue Sep 20 12:50:20 PDT 2011

On Sep 20, 2011, at 10:46 AM, Christian Thalinger wrote:

Looks good. Thanks for fixing it and the clean up.

Same here. The original code structure was mine and I like yours better.

-- John

-- Christian

On Sep 20, 2011, at 7:35 PM, Tom Rodriguez wrote:

http://cr.openjdk.java.net/~never/7092236 27 lines changed: 17 ins; 7 del; 3 mod; 1161 unchg

7092236: java/util/EnumSet/EnumSetBash.java fails Reviewed-by: The changes for 7083184 moved an early bailout outside of the guarding test which caused us to skip checking some dependencies when classes are loaded during compilation. The fix is to move it back inside. I also simplified the logic since I found it quite confusing. Tested by failing test from bug report.

More information about the hotspot-compiler-dev mailing list