Request for reviews (S): 7200264: 7192963 changes disabled shift vectors (original) (raw)

Vladimir Kozlov vladimir.kozlov at oracle.com
Mon Sep 24 11:21:24 PDT 2012

• Previous message: Request for reviews (S): 7200264: 7192963 changes disabled shift vectors
• Next message: Request for reviews (S): 7200233: C2: can't use expand rules for vector instruction rules
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Thank you, Christian

Vladimir

Christian Thalinger wrote:

Looks good. -- Chris

On Sep 21, 2012, at 3:32 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:

http://cr.openjdk.java.net/~kvn/7200264/webrev

7192963 changes disabled shift vectors when count is vector. By accident it also disable supported shift vectors when count is loop invariant value. Replaced isvectoruse() call with explicit check for vector shift's count (member of some pack). Also fixed the check in main (first) loop in profitable() method to not check for scalar promotion case (inputs are the same) which is already done in isvectoruse(). Otherwise cases when input vectors have different size or alignment may pass this check (currently they don't because constructed packs have different elements (ideal nodes) - packs are not constructed for the same inputs (scalar promotion case)). Thanks, Vladimir

• Previous message: Request for reviews (S): 7200264: 7192963 changes disabled shift vectors
• Next message: Request for reviews (S): 7200233: C2: can't use expand rules for vector instruction rules
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the hotspot-compiler-dev mailing list