Request for reviews (S): 7200233: C2: can't use expand rules for vector instruction rules (original) (raw)

Christian Thalinger christian.thalinger at oracle.com
Tue Sep 25 10:35:23 PDT 2012

• Previous message: Request for reviews (S): 7200233: C2: can't use expand rules for vector instruction rules
• Next message: Request for reviews(M): 7193318: C2: remove number of inputs requirement from Node's new operator
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sep 24, 2012, at 7:04 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:

Christian Thalinger wrote:

On Sep 21, 2012, at 4:43 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:

http://cr.openjdk.java.net/~kvn/7200233/webrev

Added missed bottomtype set in ArchDesc::defineExpand(). Added missed vector nodes in MatchRule::isvector() and in vmStructs. Looks good. But wouldn't it be better to have some kind of array with all the vector names in it for MatchRule::isvector? Done: http://cr.openjdk.java.net/~kvn/7200233/webrev.01

Much better. Thanks. -- Chris

Thanks, Vladimir

-- Chris Thanks, Vladimir

• Previous message: Request for reviews (S): 7200233: C2: can't use expand rules for vector instruction rules
• Next message: Request for reviews(M): 7193318: C2: remove number of inputs requirement from Node's new operator
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the hotspot-compiler-dev mailing list