Request for review: JDK-8032970: stack size check methods for WhiteBox API (original) (raw)

David Holmes david.holmes at oracle.com
Tue Feb 4 16:45:54 PST 2014

Not a full review but in the test:

45 static void recursive(long n) { 46 try { 47 recursive(n + 1); 48 } catch ( StackOverflowError e ) { 49 throw new SOE(wb.getThreadRemainingStackSize()); 50 } 51 }

If the call at 47 triggers SOE there is a reasonable chance that the call to wb.getThreadRemainingStackSize() will also trigger SOE, as might the "new" and invocation of the constructor. So this seems very fragile.

David

On 5/02/2014 12:15 AM, Kirill Shirokov wrote:

Hi,

Please review following webrev, which adds stack size checking methods to WhiteBox API: http://cr.openjdk.java.net/~iignatyev/kshirokov/8032970/webrev.00/ <http://cr.openjdk.java.net/%7Eiignatyev/kshirokov/8032970/webrev.00/> Thank you, Kirill p.s. JPRT build: http://bus2001067.us.oracle.com/archives/2014/01/2014-01-29-142054.iignatye.8032970/JobStatus.txt

More information about the hotspot-compiler-dev mailing list