RFR (XS): 8035887: VM crashes trying to force inlining the recursive call (original) (raw)

Christian Thalinger christian.thalinger at oracle.com
Thu Feb 27 10:01:28 PST 2014

• Previous message: RFR (XS): 8035887: VM crashes trying to force inlining the recursive call
• Next message: RFR (XS): 8035887: VM crashes trying to force inlining the recursive call
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

! const char* msg;

• if (callee->force_inline())  msg = "force inline by annotation";

• if (callee->should_inline()) msg = "force inline by CompileOracle";

• print_inlining(callee, msg);

We shouldn’t leave msg uninitialized. I know that it is not a problem with the code as it is now but it might be in the future.

On Feb 27, 2014, at 9:51 AM, Vladimir Ivanov <vladimir.x.ivanov at oracle.com> wrote:

Aleksey,

Yes, that's reasonable. C2 takes recursive calls of @ForceInline'd methods into account, so should C1. Updated webrev: http://cr.openjdk.java.net/~vlivanov/8035887/webrev.01/ Thanks for review. Best regards, Vladimir Ivanov On 2/27/14 9:18 PM, Aleksey Shipilev wrote: On 02/27/2014 09:09 PM, Vladimir Ivanov wrote:

http://cr.openjdk.java.net/~vlivanov/8035887/webrev.00/

Shouldn't there be the same recursive check for "callee->forceinline()" case as well? -Aleksey.

• Previous message: RFR (XS): 8035887: VM crashes trying to force inlining the recursive call
• Next message: RFR (XS): 8035887: VM crashes trying to force inlining the recursive call
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the hotspot-compiler-dev mailing list