RFR (XS): 8035887: VM crashes trying to force inlining the recursive call (original) (raw)

Vladimir Ivanov vladimir.x.ivanov at oracle.com
Fri Feb 28 09:13:58 PST 2014

Chris, David, thanks for review.

Yes, that's an overlook on my side.

Updated webrev: http://cr.openjdk.java.net/~vlivanov/8035887/webrev.02/

I use empty string as a default, because NULL has special meaning for print_inlining. I hope we'll clean this up some day...

Best regards, Vladimir Ivanov

On 2/28/14 8:22 PM, David Chase wrote:

On 2014-02-27, at 1:01 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:

! const char* msg; + if (callee->forceinline()) msg = "force inline by annotation"; + if (callee->shouldinline()) msg = "force inline by CompileOracle"; + printinlining(callee, msg);

We shouldn’t leave msg uninitialized. I know that it is not a problem with the code as it is now but it might be in the future. And Parfait will complain right now.

More information about the hotspot-compiler-dev mailing list