RFR(S): JDK-8032662 : test/compiler/ciReplay/TestSA.sh should report ulimit issues (original) (raw)
Igor Ignatyev igor.ignatyev at oracle.com
Fri Jan 24 07:25:48 PST 2014
- Previous message: RFR(S): JDK-8032662 : test/compiler/ciReplay/TestSA.sh should report ulimit issues
- Next message: RFR(S): JDK-8032662 : test/compiler/ciReplay/TestSA.sh should report ulimit issues
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
I'm not sure that all system returns 'unlimited', some of them may return '-1', so I'd prefer '$new_ulimit != "unlimited" -a $new_ulimit != "-1"' as the condition.
In the rest, looks good.
Igor
On 01/24/2014 07:22 PM, Vladimir Kozlov wrote:
Looks fine to me but I want Igor's opinion as well since he is the author.
Thanks, Vladimir On 1/24/14 7:09 AM, Staffan Larsen wrote: Please review this small fix to a test to provide additional diagnostics on failures.
webrev: http://cr.openjdk.java.net/~sla/8032662/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8032662 Thanks, /Staffan
- Previous message: RFR(S): JDK-8032662 : test/compiler/ciReplay/TestSA.sh should report ulimit issues
- Next message: RFR(S): JDK-8032662 : test/compiler/ciReplay/TestSA.sh should report ulimit issues
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the hotspot-compiler-dev mailing list