RFR(XS): 8073957: assert(ary_src != 0) failed: not an array or instance? (original) (raw)

Vladimir Kozlov vladimir.kozlov at oracle.com
Tue Mar 3 19:33:30 UTC 2015


Yes, looks good.

Thanks, Vladimir

On 3/3/15 11:21 AM, Roland Westrelin wrote:

Thanks for the comments.

Depending on the order of IGVN list execution different inputs could be set to top at different time. I would suggest to check all ArrayCopyNode's inputs for top.

In ideal() or ArrayCopyNode::make() we may need to test inputs (or may be assert) for NULL too. Does this look ok? http://cr.openjdk.java.net/~roland/8073957/webrev.01/ in(ArrayCopyNode::Length) is tested for top in ArrayCopyNode::getlengthifconstant() Roland.



More information about the hotspot-compiler-dev mailing list