RFR (S) : 8073607 : add trace events for inlining (original) (raw)

Igor Ignatyev igor.ignatyev at oracle.com
Tue Mar 10 16:40:50 UTC 2015

Hi Markus/Erik,

I've slightly updated the patch according to your comments:

Also I changed caller type to 'Method*'.

http://cr.openjdk.java.net/~iignatyev/8073607/webrev.01/

Igor

On 02/27/2015 01:25 PM, Markus Gronlund wrote:

Hi Igor,

In trace.xml: 404 405 406 407 You don't need to write an individual UTF8 string for every class, method and desc as we have "intrinsics" for taking care of this for you. This also means you wouldn't need to create a separate struct, as you can just define the necessary fields as type METHOD in the CompilerInlining event: <event id="CompilerInlining" path="vm/compiler/opto/inlining" label="Compiler Optimization :: Inlining"_ _410 hasthread="true" isinstant="true"> 411 412 413 414 415 416 417

// I also removed these attributes " isrequestable="false" isconstant="false" - they are defaults. I changed to "isinstant=true" since it looks like the event does not span over a duration in bytecodeInfo.cpp. At the event site, you will now need to pass the Hotspot Method* as the values (unsure how you pull that out of a ci* artifact, but you have the Metadata* for the Method there somewhere): result.setcaller(Method* callermethod); result.setcallee(Method* calleemethod); Thanks Markus -----Original Message----- From: Igor Ignatyev Sent: den 24 februari 2015 22:11 To: hotspot-compiler-dev at openjdk.java.net compiler; serviceability-dev at openjdk.java.net Subject: RFR (S) : 8073607 : add trace events for inlining Hi guys, could you please review the patch which adds trace events for inlining for c1/c2 compiler? An added event provides information about caller, callee, bci, inline status and message. webrev : http://cr.openjdk.java.net/~iignatyev/8073607/webrev.00/ JBS: https://bugs.openjdk.java.net/browse/JDK-8073607 -- Igor

More information about the hotspot-compiler-dev mailing list