RFR(XS): 8075921: assert assert(allocx == alloc) fails in library_call.cpp (original) (raw)

Roland Westrelin roland.westrelin at oracle.com
Tue Mar 31 07:48:41 UTC 2015

• Previous message: RFR(XS): 8075921: assert assert(allocx == alloc) fails in library_call.cpp
• Next message: RFR(XS): 8075922: assert(t == t_no_spec) fails in phaseX.cpp
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Thanks for the review, Vladimir (K). And thanks for the initial review, Vladimir (I).

Roland.

On Mar 30, 2015, at 7:51 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:

Okay, good. Thanks, Vladimir On 3/27/15 6:11 AM, Roland Westrelin wrote: Hi Vladimir,

Thanks for looking at this.

Null checks can also make stop fast path in inlinearraycopy(). I think you should add some stopped() checks there too if needed. All guards can stop the fast path, not only the null checks. What about this: http://cr.openjdk.java.net/~roland/8075921/webrev.01/ Some code that generates guards already check for stopped(). I’ve added new checks only where they were missing. Roland.

Thanks, Vladimir On 3/26/15 6:10 AM, Roland Westrelin wrote: http://cr.openjdk.java.net/~roland/8075921/webrev.00/ During arraycopy intrinsic construction, control becomes top after arraycopy guards are added and that confuses the logic that moves the tightly coupled allocation. Roland.

• Previous message: RFR(XS): 8075921: assert assert(allocx == alloc) fails in library_call.cpp
• Next message: RFR(XS): 8075922: assert(t == t_no_spec) fails in phaseX.cpp
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the hotspot-compiler-dev mailing list