Review request: 8003935: Simplify the needed includes for using Thread::current() (original) (raw)
Stefan Karlsson stefan.karlsson at oracle.com
Fri Nov 23 03:54:53 PST 2012
- Previous message: RFR(S): Fix generation of malformed options for Projectcreator
- Next message: Review request: 8003935: Simplify the needed includes for using Thread::current()
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
http://cr.openjdk.java.net/~stefank/8003935/webrev
Today, whenever we use Thread::current() we have to all these lines:
#include "runtime/thread.hpp" #ifdef TARGET_OS_FAMILY_linux
include "thread_linux.inline.hpp"
#endif #ifdef TARGET_OS_FAMILY_solaris
include "thread_solaris.inline.hpp"
#endif #ifdef TARGET_OS_FAMILY_windows
include "thread_windows.inline.hpp"
#endif #ifdef TARGET_OS_FAMILY_bsd
include "thread_bsd.inline.hpp"
#endif
This patch hides this dispatching in a new file named thread.inline.hpp. Now we only have to include thread.inline.hpp.
Some background to these includes: This type of dispatching was introduced into the source files when we removed the includeDB files. We discussed whether we should use "dispatch files" or not for this kind platform dependent includes. The decision was to not create dispatch files for all types of platform at that time, but instead manually create them when we thought it was warranted.
thanks, StefanK
- Previous message: RFR(S): Fix generation of malformed options for Projectcreator
- Next message: Review request: 8003935: Simplify the needed includes for using Thread::current()
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]