Request for review- RFE 8005716 (original) (raw)

BILL PITTORE bill.pittore at oracle.com
Wed Mar 6 12:43:10 PST 2013

Actually for windows I did export the undecorated name. I just didn't see where I did it in the VS IDE. If you don't export the undecorated name it doesn't work of course.

bill

On 3/5/2013 11:13 PM, BILL PITTORE wrote:

On 3/5/2013 7:36 PM, Dean Long wrote:

If JNIONLOADSYMBOLS contains something like "JNIOnLoad at 8" on Windows, you can't just turn that into "JNIOnLoad at 8" + . I think it needs to be "JNIOnLoad" + + "@8" I'll look into that. When I built for windows and ran our test, the JNIOnLoadTestStaticLib was exported without the decoration just based on the JNIEXPORT JNICALL specifiers on the function. I didn't do anything special to export it. But I recall this problem from another project. 1 0 00001014 JNIOnLoadTestStaticLib = @ILT+15(?JNIOnLoadTestStaticLib@@YGHPAUJavaVM@@PAX at Z)

Looks like onLoadSymbols[] is unused in JavajavalangClassLoader00024NativeLibraryfindBuiltinLib(). I'll remove that. I redid the call to findBuiltinJniFunction but forgot to remove that.

Instead of adding getProcessHandle(), why not add JVMFindBuiltinLibraryEntry() instead? This would make it easier to support table-lookup when runtime symbol information is missing or not supported by the platform. Not sure I'm following you on this. Make JVMFindBuiltinLibraryEntry() an exported function in the VM? How does it find JNIOnLoadL? Via a table setup by the developer/build system when the library is linked in? bill dl On 3/5/2013 3:05 PM, bill.pittore at oracle.com wrote: This request is tied to bugid 8005716 that deals with adding support for statically linked JNI libraries.

The JEP is here: http://openjdk.java.net/jeps/178 The bug is here:http://bugs.sun.com/viewbug.do?bugid=8005716 The webrevs are here: http://cr.openjdk.java.net/~bpittore/8005716/jdk-webrev.00/ http://cr.openjdk.java.net/~bpittore/8005716/hs-webrev.00/ The main piece of functionality is to check for the presence of JNIOnLoadlibname to determine if the library specified by 'libname' has been statically linked into the VM. If the symbol is found, it is assumed that the library is linked in and will not be dynamically loaded. thanks, bill

More information about the hotspot-dev mailing list