Request for review (XS): 8010116: Abstract_VM_Version::internal_vm_info_string() should recognize VS2010 and VS2012 (original) (raw)
Krystal Mo krystal.mo at oracle.com
Thu Mar 14 12:44:15 PDT 2013
- Previous message: hg: hsx/hotspot-main/hotspot: 7 new changesets
- Next message: Request for review (XS): 8010116: Abstract_VM_Version::internal_vm_info_string() should recognize VS2010 and VS2012
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi all,
Could I get a review for this small fix, please?
Webrev: http://cr.openjdk.java.net/~kmo/8010116/webrev.00/ CR: http://bugs.sun.com/view_bug.do?bug_id=8010116
Description:
Currently Abstract_VM_Version::internal_vm_info_string() recognizes MSVC versions from 5.0 to 9.0 (VS2008). Since JDK7 can be and is being built with VS2010, it should recognize that compiler (along with new VS2012), so that when its value appears in crash logs, it shouldn't say: "unknown MS VC++:1600", which is what can be seen in JDK7u's crash log.
Thanks, Kris
- Previous message: hg: hsx/hotspot-main/hotspot: 7 new changesets
- Next message: Request for review (XS): 8010116: Abstract_VM_Version::internal_vm_info_string() should recognize VS2010 and VS2012
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]