Review Request: 8002118: WindbgDebuggerLocal should not try to load 64-bit debug libraries for 32-bit JVM (original) (raw)
Zhengyu Gu zhengyu.gu at oracle.com
Wed Mar 27 10:03:47 PDT 2013
- Previous message: Review Request: 8002118: WindbgDebuggerLocal should not try to load 64-bit debug libraries for 32-bit JVM
- Next message: Review Request: 8002118: WindbgDebuggerLocal should not try to load 64-bit debug libraries for 32-bit JVM
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Looks good to me.
-Zhengyu
On 3/27/2013 12:29 PM, Peter Allwin wrote:
Webrev: http://cr.openjdk.java.net/~sla/peter/8002118/webrev.01/
CR: http://bugs.sun.com/viewbug.do?bugid=8002118 https://jbs.oracle.com/bugs/browse/JDK-8002118
Problem is that on Windows we probe for dbghelp.dll on a number of different places, and that list always included \Program Files\Debugging Tools for Windows (x64) even if we're running x86, leading to an UnsatisfiedLinkError during load. Fix is to add the ...(x64) path only if we're on amd64, and ...(x86) only if we're on x86. The affected tests have been verified to work with this fix. Thanks to Staffan for helping out and hosting the webrev! Regards, /peter
- Previous message: Review Request: 8002118: WindbgDebuggerLocal should not try to load 64-bit debug libraries for 32-bit JVM
- Next message: Review Request: 8002118: WindbgDebuggerLocal should not try to load 64-bit debug libraries for 32-bit JVM
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]