RFR(S): JDK-8033126 : Can't call default methods from JNI (original) (raw)
Staffan Larsen staffan.larsen at oracle.com
Mon Feb 3 06:26:14 PST 2014
- Previous message: RFR (XS) 6471769: Error: assert(_cur_stack_depth == count_frames(), "cur_stack_depth out of sync")
- Next message: RFR (XS) 6471769: Error: assert(_cur_stack_depth == count_frames(), "cur_stack_depth out of sync")
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Karen,
I have pushed this change without the assertion. Given the problems with creating test cases with JNI code, I plan to file a follow-up bug for the testcase.
Thanks, /Staffan
On 29 jan 2014, at 15:28, Karen Kinnear <karen.kinnear at oracle.com> wrote:
Staffan,
Fix approach looks good. Can you please remove the assertion - I don't think that will always be true. Can you please submit an automated testcase with this? thanks, Karen On Jan 29, 2014, at 8:17 AM, Staffan Larsen wrote:
This is a more formal review request for the patch proposed in [0]
webrev: http://cr.openjdk.java.net/~sla/8033126/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8033126 The bug report has a reproducer/testcase that I have used to verify the fix. I have also run the vm/jni tests in the JCK. Thanks, /Staffan [0] http://mail.openjdk.java.net/pipermail/hotspot-dev/2014-January/012325.html
- Previous message: RFR (XS) 6471769: Error: assert(_cur_stack_depth == count_frames(), "cur_stack_depth out of sync")
- Next message: RFR (XS) 6471769: Error: assert(_cur_stack_depth == count_frames(), "cur_stack_depth out of sync")
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]