[7u60] RFR 8024648 : 8016131 breaks Zero port (original) (raw)

Alejandro E Murillo alejandro.murillo at oracle.com
Thu Feb 13 22:52:03 PST 2014

On 2/13/2014 9:47 PM, Andrew Hughes wrote:

----- Original Message -----

To expand on a solution for this ...

Note that in vm.make and gcc.make the only uses of the JVMVARIANT variables relates to ZERO and ZEROSHARK. That is the real problem in my view (it was natural to use them as they were very prominent). Looking through the build process it seems to me that in the generated flags.make we will have: include zero|shark.make include gcc.make And in zero|shark.make we have TYPE=ZERO or TYPE=SHARK. So TYPE can be used in gcc.make instead of the JVMVARIANT* variable. (BUILDARCH will also be zero but that doesn't help with shark.) Aside: note that here zero or shark is the VARIANT but that isn't exposed in the generated makefiles as the VARIANT is already implicit in the path to which the file was generated eg hotspot//product Similarly the generated vm.make will include flags.make before the repo version of vm.make so it too can use TYPE to identify ZERO or SHARK. If I knew how to build zero/shark I'd test this out. :( David ----- This is a revised webrev using $(TYPE) in gcc.make and vm.make instead: http://cr.openjdk.java.net/~andrew/jdk7u/8024648/webrev.02/ The BSD changes mirror the GNU/Linux ones, as in the 7141426 change which broke the build, but I've no means to test on that platform. I'll submit a couple of jprt jobs with these changes thanks

-- Alejandro

More information about the hotspot-dev mailing list