RFR(M): 8034171: Remove use of template template parameters from binaryTreeDictionary. (original) (raw)

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Thu Feb 13 23:24:33 PST 2014

Hi Jon,

Thanks for your review!

Best regards, Goetz.

-----Original Message----- From: Jon Masamitsu [mailto:jon.masamitsu at oracle.com] Sent: Donnerstag, 13. Februar 2014 22:39 To: Lindenmaier, Goetz; 'hotspot-dev at openjdk.java.net'; 'hotspot-runtime-dev at openjdk.java.net'; 'Mikael Gerdin (mikael.gerdin at oracle.com)' Cc: Baesken, Matthias Subject: Re: RFR(M): 8034171: Remove use of template template parameters from binaryTreeDictionary.

This is a very nice change. Thanks.

Looks good.

Jon

On 02/11/2014 01:02 AM, Lindenmaier, Goetz wrote:

Hi,

The template template parameters in the binaryTreeDictionary are not needed to express its functionality. This change replaces them by simple class templates and explicit instantiation. This simplifies consumption of the openJDK in scenarios requiring older C++ compilers. This change also removes dead getchunk() from binaryTreeDictionary.cpp. Bug: https://bugs.openjdk.java.net/browse/JDK-8034171 webrev: http://cr.openjdk.java.net/~goetz/webrevs/8034171-1-templ/ Please review and test this change. Unfortunately I don't have access to JPRT, so I need a sponsor.

I compiled this change on linuxx8664 with gcc 4.3.4 and 4.8, and on sparcv9 with SS12u1, on windows amd64 and on sparc. I tested dbg, fdbg and opt builds. The change ran with all our tests on the ppc port, including jbb2013, jvm2008 and parts of a well-known, publicly not available test suite without problems.

I would like to downport this change to jdk8u targeting u20 later on. Could you please also check whether I filed the bug correctly? What should I put into "affected versions"? Thanks and best regards, Goetz.

More information about the hotspot-dev mailing list