8030350 breaks build with older gccs. (original) (raw)

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Tue Feb 25 03:42:21 PST 2014

Hi Mike,

your change breaks the build with older gccs as they don't know the option "-Wno-error=format-nonliteral"

I saw this with gcc 4.1.2 on linuxppc64 and linuxx86_64, and with gcc 3.3.3 on linuxx86_64. Gcc 4.3.4 works.

In the mail thread I saw that you opened some bugs to fix further warnings, maybe you detected this issue already, or there is a bug to fix this?

I would propose to fix this by either adapting hotspot code not to issue these warnings: http://cr.openjdk.java.net/~goetz/webrevs/fix_hotspot/ or to adapt the makefiles not to use the warning on older gccs: http://cr.openjdk.java.net/~goetz/webrevs/fix_makefiles/

If you give me advice what you would prefer, I will open a bug and send a RFR.

Best regards, Goetz.