8030350 breaks build with older gccs. (original) (raw)

David Holmes david.holmes at oracle.com
Tue Feb 25 20:26:35 PST 2014

On 25/02/2014 10:54 PM, David Holmes wrote:

On 25/02/2014 9:42 PM, Lindenmaier, Goetz wrote:

Hi Mike,

your change breaks the build with older gccs as they don't know the option "-Wno-error=format-nonliteral" I saw this with gcc 4.1.2 on linuxppc64 and linuxx8664, and with gcc 3.3.3 on linuxx8664. Gcc 4.3.4 works. In the mail thread I saw that you opened some bugs to fix further warnings, maybe you detected this issue already, or there is a bug to fix this? I would propose to fix this by either adapting hotspot code not to issue these warnings: I think Mike already did this for hotspot.

Sorry got myself confused - forgot where Mike ended up on this one.

David

http://cr.openjdk.java.net/~goetz/webrevs/fixhotspot/ or to adapt the makefiles not to use the warning on older gccs: http://cr.openjdk.java.net/~goetz/webrevs/fixmakefiles/ Or accept that there is a minimum gcc level expected as the build tool. David -----

If you give me advice what you would prefer, I will open a bug and send a RFR.

Best regards, Goetz.

More information about the hotspot-dev mailing list