RFR: 8035746: Add missing Klass::oop_is_instanceClassLoader() function (original) (raw)

Coleen Phillimore coleen.phillimore at oracle.com
Wed Feb 26 11:38:48 PST 2014

On 2/25/2014 12:50 PM, Stefan Karlsson wrote:

On 2014-02-25 15:15, Mikael Gerdin wrote:

Hi Stefan,

On Tuesday 25 February 2014 14.43.49 Stefan Karlsson wrote: Hi all,

Please, review this small patch to add Klass::oopisinstanceClassLoader(). Webrev: http://cr.openjdk.java.net/~stefank/8035746/webrev.00 Code change looks good. Thanks. There are a couple of places where we check whether or not a Klass is a ClassLoader, something like: if (klass->issubclassof(SystemDictionary::ClassLoaderklass())) These places could now be changed to klass->oopisClassLoader(), saving a possibly expensive subtype check. Should we file an RFE to change these or do you want to change them straight away? I'd prefer a separate RFE.

This change looks good. I assume this is actually for G1 class unloading. Too bad though I wish you'd change it all in one pass.

Thanks, Coleen

thanks, StefanK

/Mikael RFE: https://bugs.openjdk.java.net/browse/JDK-8035746

thanks, StefanK

More information about the hotspot-dev mailing list