RFR 8035735: Metaspace::contains become extremely slow in some cases (original) (raw)
Daniel D. Daugherty daniel.daugherty at oracle.com
Fri Feb 28 14:03:18 PST 2014
- Previous message: RFR 8035735: Metaspace::contains become extremely slow in some cases
- Next message: RFR 8035735: Metaspace::contains become extremely slow in some cases
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 2/28/14 1:08 PM, Coleen Phillimore wrote:
Summary: Call ismetadata instead which does less work for the call in debugInfo.hpp which is called for all compiled code stack frames.
open webrev at http://cr.openjdk.java.net/~coleenp/8035735/
src/share/vm/code/debugInfo.hpp line 276: // is_metadata is a faster check In the context of the current code review, the comment is fine, but when you read it down the road (by itself), you'll ask yourself: Faster than what? :-)
Perhaps:
// is_metadata() is a faster check than is_metaspace_object()src/share/vm/oops/metadata.hpp No comments.
Thumbs up, modulo Jon M's question...
Dan
bug link https://bugs.openjdk.java.net/browse/JDK-8035735
Tested with failing test case, nsk.quick.testlist, jcks and jtreg tests. Coleen
- Previous message: RFR 8035735: Metaspace::contains become extremely slow in some cases
- Next message: RFR 8035735: Metaspace::contains become extremely slow in some cases
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]