RFR(XS) : 8028482 : [TESTBUG] tests that use JMX should be in need_compact3 test group (original) (raw)

David Holmes david.holmes at oracle.com
Tue Jan 21 17:49:18 PST 2014

On 21/01/2014 11:04 PM, Igor Ignatyev wrote:

I will file an RFE to get rid of JMX in CompilerWhiteBoxTest.

Thanks. Will need to remember to revert this change then too.

Can I count you as an reviewer?

Yes - sorry that wasn't clear.

Thanks, David

Igor

On 01/21/2014 03:55 PM, David Holmes wrote: On 21/01/2014 7:41 PM, Igor Ignatyev wrote:

Hi David,

Whitebox API itself doesn't use JMX, but CompilerWhiteBoxTest, super-class of these tests, uses it. I see. That is unfortunate as it constrains the test environment for users of the Whitebox API even if they don't need the JMX part directly. Whomever owns this should see if they can rectify this some how. Thanks, David Igor On 01/21/2014 07:01 AM, David Holmes wrote: Hi Igor,

On 20/01/2014 10:27 PM, Igor Ignatyev wrote: Hi all,

Please review patch: Problem: tests 'compiler/tiered/NonTieredLevelsTest.java' and 'TieredLevelsTest.java' use JMX, but not in 'needcompact3' test group I don't see any direct JMX use in those tests. Is it coming in via the Whitebox API? That would be unfortunate. Thanks, David

Fix: tests are added into 'needcompact3' webrev: http://cr.openjdk.java.net/~iignatyev/8028482/webrev.00/ jbs: https://bugs.openjdk.java.net/browse/JDK-8028482

More information about the hotspot-dev mailing list