RFR(XXS): 8076532: Fix format warning/error in methodHandles_ppc.cpp (original) (raw)

Volker Simonis volker.simonis at gmail.com
Thu Apr 2 09:19:28 UTC 2015

Thanks David!

Volker

On Thu, Apr 2, 2015 at 11:17 AM, David Holmes <david.holmes at oracle.com> wrote:

Looks fine Volker!

Thanks, David

On 2/04/2015 7:12 PM, Volker Simonis wrote:

Hi, can I please get a review for this tiny, ppc-only change: https://bugs.openjdk.java.net/browse/JDK-8076532 http://cr.openjdk.java.net/~simonis/webrevs/2015/8076532/ With newer GCCs we currently get the following warning/error: methodHandlesppc.cpp: In function ‘void tracemethodhandlestub(const char*, oopDesc*, intptrt*, intptrt*)’: methodHandlesppc.cpp:469:66: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 6 has type ‘intptrt* {aka long int*}’ [-Werror=format=] adaptername, mhregname, (intptrt) mh, entrysp); for this code code in methodHandlesppc.cpp: tty->printcr("MH %s %s="INTPTRFORMAT " sp=" INTPTRFORMAT, adaptername, mhregname, (intptrt) mh, entrysp); The fix is trivial - just use the "p2i()" helper function to cast the pointers to the appropriate type: tty->printcr("MH %s %s="INTPTRFORMAT " sp=" INTPTRFORMAT, adaptername, mhregname, p2i(mh), p2i(entrysp));

Thanks, Volker

More information about the hotspot-dev mailing list