RFR(S): 8077618: Move rtmLocking.cpp to shared directory. (original) (raw)
David Holmes david.holmes at oracle.com
Tue Apr 14 01:36:30 UTC 2015
- Previous message: RFR(S): 8077618: Move rtmLocking.cpp to shared directory.
- Next message: RFR(S): 8077618: Move rtmLocking.cpp to shared directory.
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Goetz,
On 14/04/2015 1:57 AM, Lindenmaier, Goetz wrote:
Hi,
we implemented support for Transactional Memory on ppc. For this, we need the file rtmLocking.cpp from subdirectory x86 as is. Therefore I would like to move the file to share/vm/runtime, where the corresponding header is placed. I added a guard around the code in this file.
Not sure if we need the guard in the cpp file - I guess it speeds up compilation a tiny amount :) If we do want it then the copyright date needs updating to "2014, 2015,".
Also, I moved #ifdef x86 from globalDefinitions.hpp to globalDefinitionsx86.hpp which simplifies enabling RTM on PPC.
Copyright date in src/cpu/x86/vm/globalDefinitions_x86.hpp needs updating.
Please review this change. I please need a sponsor. http://cr.openjdk.java.net/~goetz/webrevs/8077618-mvRTM/webrev.01/
Otherwise looks okay.
David
Best regards, Goetz.
- Previous message: RFR(S): 8077618: Move rtmLocking.cpp to shared directory.
- Next message: RFR(S): 8077618: Move rtmLocking.cpp to shared directory.
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]