RFR: 8077615: AARCH64: Add C2 intrinsic for BigInteger::multiplyToLen() method (original) (raw)

Vladimir Kozlov vladimir.kozlov at oracle.com
Tue Apr 14 17:25:03 UTC 2015

Looks good. I will push it through JPRT since it has shared code change (test).

Thanks, Vladimir

On 4/14/15 3:10 AM, Andrew Haley wrote:

On 04/13/2015 08:12 PM, Vladimir Kozlov wrote:

In the test you removed next line from previous test. Can you restore them?:

System.out.println(b1); System.out.println(b2); Oops. It was hard to see that in the diff. I have a little problem of mapping code from comments to assembler for multiply64x64loop(). Extend comments. I think in next comments xxstart should be used on left side instead of 'product': Yes. + umulh(rscratch1, xxstart, yidx); // product * yidx -> rscratch1:product + mul(product, xxstart, yidx); + adds(product, product, carry); + adc(carry, rscratch1, zr); // product * yidx + carry -> carry:product Also why not use BytesPerLong instead of BytesPerWord?: OK. Also, I did a new merge and the port no longer built: /local/aarch64/dev/hotspot/src/cpu/aarch64/vm/macroAssembleraarch64.hpp:61:16: error: 'virtual void MacroAssembler::callVMleafbase(address, int, Label&)' was hidden [-Werror=overloaded-virtual] VIRTUAL void callVMleafbase( ^ This is a correct warning message, so I added a using directive to clarify the intent. http://cr.openjdk.java.net/~aph/8077615-1/ Andrew.

More information about the hotspot-dev mailing list