RFR: 8078521: AARCH64: Add AArch64 SA support (original) (raw)
Dean Long dean.long at oracle.com
Fri Apr 24 18:27:44 UTC 2015
- Previous message: RFR: 8078521: AARCH64: Add AArch64 SA support
- Next message: RFR: 8078521: AARCH64: Add AArch64 SA support
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Not a review, but a couple things I noticed:
agent/src/os/linux/ps_proc.c:
I don't think you need to change this file. There is already PTRACE_GETREGSET support there.
agent/src/os/linux/Makefile:
echo FECK
The conflict will be handled in a separate bug (8078632).
dl
On 4/24/2015 1:39 AM, Andrew Haley wrote:
On 23/04/15 21:23, Dean Long wrote:
On 4/23/2015 9:22 AM, Andrew Haley wrote:
http://cr.openjdk.java.net/~aph/8078521/ Unfortunately, this will cause conflicts with our closed port. I thought it might. The assumption that a CPU name uniquely identifies a port has turned out not to be true. I don't know if we should try to address those issues here or in a followup bug. I think this should be done in a followup bug. IMO there's nothing much wrong with this except that it breaks something externally invisible. We would need something like the following (still untested) to allow us to map to a different cpu name: Yes, I see. Andrew.
- Previous message: RFR: 8078521: AARCH64: Add AArch64 SA support
- Next message: RFR: 8078521: AARCH64: Add AArch64 SA support
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]