RFR: JDK-8075327: Merge jdk and hotspot test libraries (original) (raw)

Alexander Kulyakhtin alexander.kulyakhtin at oracle.com
Tue Jun 2 16:26:29 UTC 2015

Hi Ivan,

I did my changes using hs-rt repository. The file you mention is not there yet. I'm going to do the changes to this and any other possible new jdk files as a follow up to this bulk change. The goal of the webrev is to receive approval of the way the test libraries are going to be merged.

Best regards, Alexander

----- Original Message ----- From: ivan.gerasimov at oracle.com To: alexander.kulyakhtin at oracle.com, jdk9-dev at openjdk.java.net, hotspot-dev at openjdk.java.net Sent: Tuesday, June 2, 2015 6:44:33 PM GMT +03:00 Iraq Subject: Re: RFR: JDK-8075327: Merge jdk and hotspot test libraries

Hi Alexander!

Would you please include jdk/test/lib/testlibrary/jdk/testlibrary/OptimalCapacity.java in the webrev? This file was added recently with the fix for JDK-8081027

It's currently used from the following three tests, which will need to be updated too: jdk/test/java/lang/Character/UnicodeBlock/OptimalMapSize.java jdk/test/sun/invoke/anon/ConstantPoolPatch/OptimalMapSize.java jdk/test/sun/security/ssl/ExtensionType/OptimalListSize.java

Sincerely yours, Ivan

On 02.06.2015 14:18, Alexander Kulyakhtin wrote:

Hi,

Could you, please, review the following test-only changes to the 'jdk', 'hotspot' and the common 'test' repository http://cr.openjdk.java.net/~akulyakh/8075327/wrhs/webrev.01/index.html http://cr.openjdk.java.net/~akulyakh/8075327/wrjdk/webrev.01/index.html http://cr.openjdk.java.net/~akulyakh/8075327/wrtest/webrev.01/ The changes are to move test library files common to both jdk and hotspot to the upper-level test repository. The following has been done: 1) Common files (Asserts.java, OutputAnalyzer.java etc) from the jdk and hotspot repositories, have been merged and moved to the upper-level common test repository, to test/lib/share/classes. 2) Package jdk.testlibrary in the jdk repository have been renamed to jdk.test.lib to have the same name as in the hotspot repository 2) Upper level test/lib/share/classes library references have been added to the @library statements 3) Some packages previously located at upper level test repo at /test/lib have been moved to /test/lib/share/classes for consistency Best regards, Alexander

More information about the hotspot-dev mailing list